Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin generation of Bundle elements is now mandatory #2547

Merged
merged 1 commit into from
May 27, 2022

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented May 26, 2022

Feature originally added in v3.5.1, it was technically a binary incompatible change so in v3.6.0 it will become mandatory.

This enables removing reflection.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • performance improvement
  • code cleanup

API Impact

No impact since the plugin is required and the same names are given.

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Make Chisel-plugin generation of Bundle.elements mandatory. Scalac option -P:chiselplugin:genBundleElements no longer does anything.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.6.0 milestone May 26, 2022
This required implementing _elementsImpl manually for all HWTuple
classes (which do not have the plugin run on them).
@jackkoenig jackkoenig force-pushed the always-gen-bundle-elements branch from 5810f1c to ca8adaa Compare May 26, 2022 23:09
Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp! Exciting.

@jackkoenig jackkoenig merged commit a68fdec into master May 27, 2022
@jackkoenig jackkoenig deleted the always-gen-bundle-elements branch May 27, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants